This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Display a spacer cell instead of TOS when host apps remove the link to WP.com terms of service. #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mindgraffiti
approved these changes
Dec 14, 2020
Contributor
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
I think you will want to un-check User Interaction Enabled for the spacer cell, otherwise VoiceOver will attempt to identify it. I'm unable to test and confirm this claim because my device isn't registered for Woo use.
Other than that, 
!
ScoutHarris
reviewed
Dec 14, 2020
WordPressAuthenticator.podspec
Outdated
| Pod::Spec.new do |s| | ||
| s.name = "WordPressAuthenticator" | ||
| s.version = "1.31.0-beta.5" | ||
| s.version = "1.31.0-beta.6" |
Contributor
There was a problem hiding this comment.
Since the new release was cut today, this should probably be 1.32.0-beta.1 after @jkmassel finishes the releases.
Contributor
Author
|
Thanks @mindgraffiti @ScoutHarris I'll merge develop into the branch, un-check userInteractionEnabled, update the podspec and merge 😊 |
# Conflicts: # WordPressAuthenticator.podspec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #543
Ref: woocommerce/woocommerce-ios#3309
Ref: woocommerce/woocommerce-ios#3330
PR in WooCommerce: woocommerce/woocommerce-ios#3339
The way I implemented the removal of the TOS was by just removing the cell from the table view. That makes the bottom hairline in the email textfield cell to sit right above the top margin of the Continue button.
I considered just hiding the TOS button instead of removing the cell completely (you can see that if you look at this very PR history) but in the end I thought a Spacer cell (a completely empty one) might be a better way to handle this.
Changes
How to test